fix: refactor resulting in miss TS type #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #543 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 3 3
Lines 306 306
Branches 136 136
=======================================
Hits 302 302
Misses 4 4 ☔ View full report in Codecov by Sentry. |
| @@ -1,2 +1,2 @@ | |||
| export { default } from './Pagination'; | |||
| export type { PaginationProps } from './interface'; | |||
| export type * from './interface'; | |||
There was a problem hiding this comment.
@afc163 This change is causing an issue when I am attempting to build with the latest version of rc-pagination
I'm seeing:
> tsc -b
node_modules/rc-pagination/lib/index.d.ts:2:1 - error TS1383: Only named exports may use 'export type'.
2 export type * from './interface';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
If you change this to export * from ./interfaceI believe things will do what you want and avoids this typescript error. This works fine becauseinterface.ts` is just a collection of types
There was a problem hiding this comment.
Could you provide a reproduce codesandbox?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
antd used： https://github.com/ant-design/ant-design/blob/3146699941268fc262e4d65d1bb5d107e598198c/components/pagination/Pagination.tsx#L6