Pulls OSut v0.5.0 #114
Merged
Pulls OSut v0.5.0 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brgix
commented
Apr 4, 2024
| @@ -251,7 +251,7 @@ def faces(s = {}, e = {}) | |||
| # | |||
| # @return [Topolys::Vector3D] true normal vector of s | |||
| # @return [nil] if invalid input (see logs) | |||
| def trueNormal(s = nil, r = 0) | |||
| def truNormal(s = nil, r = 0) | |||
There was a problem hiding this comment.
Distinguishes OSut's trueNormal from TBD's internal truNormal. The obvious way around this is proper namespaces, but this will do for now.
brgix
commented
Apr 13, 2024
| end | ||
|
|
||
| angle = reference_V.angle(farthest_V) | ||
| angle = 0 if angle.nil? |
There was a problem hiding this comment.
There are at least 2 circumstances that can trigger a nilled polar angle (around an edge):
- a "tiny" (i.e. invalid) surface, e.g. the width of one's finger
- when edges are "leader lines", as briefly discussed here
Getting the polar angle right allows TBD to distinguish concave vs convex corners, for instance. But in other cases, it has no effect (e.g. transition edges). The raised error was initially justified when dealing with bad geometry (something the user should remedy), yet "leader lines" (i.e. transition edges) shouldn't raise such an error. Simpler here to just mute the error entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary testing of OSut v0.5.0 (branch "geo"), a TBD dependency. Although 99% done, there are likely minor improvements to add to OSut before releasing later this month. Very minor adjustments are expected for TBD (i.e. no anticipated change in test results).