More robust 'addSkylights' (+ dependencies) #20

brgix · 2024-10-02T15:16:27Z

Significant changes to addSkylights, including quite a few dependencies!

Most of the tests included in this repository will offer little (to no) change when comparing outcomes/results (vs current release), following this merge. However, recent testing (of several very large 3rd-party models) have underlined a lack of robustness when it comes to challenging conditions (e.g. very convoluted roof surfaces). Unfortunately, it is not possible to include these 3rd-party models here - a separate private fork will be maintained to ensure harmonization.

Comments + visuals to come ...

brgix · 2024-10-02T19:40:58Z

lib/osut/utils.rb

@@ -2054,7 +2054,7 @@ def setpoints(space = nil)
        res[:heating] = nil
        res[:cooling] = nil
      elsif cnd.downcase == "semiheated"
-        res[:heating] = 15.0 if res[:heating].nil?
+        res[:heating] = 14.0 if res[:heating].nil?


A first of a handful of changes unrelated to skylights.

The Canadian NECBs use a "< 15°C" threshold (not "<= 15°C") to determine whether a space/zone is considered SEMIHEATED.

brgix · 2024-10-02T19:47:30Z

lib/osut/utils.rb

+    return mismatch("space", space, cl, mth, DBG, false) unless space.is_a?(cl)
+
+    # 1. First check OSut's REFRIGERATED status.
+    status = space.additionalProperties.getFeatureAsString(tg0)


Similar to plenum? and vestibule?, refrigerated? gives priority to an AdditionalProperties tag (useful e.g. when thermal zoning is in an incomplete state).

brgix · 2024-10-02T19:50:25Z

lib/osut/utils.rb

@@ -2945,9 +2999,16 @@ def getLineIntersection(s1 = [], s2 = [])
    a1b2  = b2 - a1
    xa1b1 = a.cross(a1b1)
    xa1b2 = a.cross(a1b2)
+    xa1b1.normalize
+    xa1b2.normalize
+    xab.normalize


Quite the oversight not to normalize, especially when dealing with one line segment possibly orders of magnitude longer than the other.

brgix · 2024-10-02T19:53:51Z

lib/osut/utils.rb


      segments.each do |sg|
        intersect = getLineIntersection([p0, p1], sg)
        next unless intersect

-        # One of the polygon vertices?
+        # Skip test altogether if one of the polygon vertices.


These collisions are challenging to deal with - easier to skip them altogether.

brgix · 2024-10-02T20:09:54Z

lib/osut/utils.rb

+  #
+  # @return [Bool] if considered a roof surface
+  # @return [false] if invalid input (see logs)
+  def roof?(pts = nil)


Single-span, prefab arched structures often end up with tilted side walls that share the same construction as their neighbouring roof segments. Quite common in single story industrial facilities (e.g. NorsemanStructures):

Am sometimes encountering OpenStudio models where such side walls end up typed as roofs, possibly to facilitate default construction inheritance. Understandable, yet energy codes (90.1, NECBs) are pretty clear: once a roof's outward normal is tilted too far away from zenith, it's considered a wall (i.e. not a candidate surface for skylights).

brgix · 2024-10-02T20:21:33Z

lib/osut/utils.rb

+    getSegments(p1).each do |sg|
+      mp = midpoint(sg.first, sg.last)
+      return false unless pointWithinPolygon?(mp, p2)
+    end


This is an expensive add-on, but essential when dealing with convoluted surfaces, namely holding multiple sequential concavities, like C-shaped or G-shaped corridors. Want to speed things up? Break up such a surface into multiple convex ones.

brgix · 2024-10-02T20:29:04Z

lib/osut/utils.rb

+    unless [true, false].include?(force)
+      log(DBG, "Ignoring force input (#{mth})")
+      force = false
+    end


This option became key to systematize the treatment of roof surfaces, whether flat, low-sloped, etc.

brgix · 2024-10-02T20:36:38Z

lib/osut/utils.rb

+      # Roof vs ceiling may neither share alignment transformation nor space
+      # site transformation identities. All subsequent calls to 'genAnchors'
+      # shall recover the :out points, apply a succession of de/alignments and
+      # transformations in sync , and overwrite tagged points.


This redesign (or rather a more systematic application of an original principle) became necessary when trying to manage multiple skylight arrays for a single roof surface (e.g. a large unconditioned attic roof sheltering a dozen conditioned spaces below).

brgix · 2024-10-02T20:40:51Z

lib/osut/utils.rb

-      next unless o[:set]
-
-      st[:out] = o
-      st[:bx ] = blc(o[:r] * (o[:t] * o[:set]))


Bounded boxes are systematically bottom-left-cornered (BLC) - no longer any need to post-process them all.

brgix · 2024-10-02T20:46:40Z

lib/osut/utils.rb

  # @param bfr [#to_f] safety buffer, to maintain near other edges
  #
  # @return [Bool] whether addition is successful
  # @return [false] if invalid input (see logs)
-  def addSubs(s = nil, subs = [], clear = false, bfr = 0.005)
+  def addSubs(s = nil, subs = [], clear = false, bound = false, realign = false, bfr = 0.005)


Setting options bound and realign to true became key to the systematic treatment of roofs (as candidates for skylights), whether flat, low sloped, etc.

brgix · 2024-10-02T20:55:18Z

lib/osut/utils.rb

+  # @option opts [#to_f] :size (1.22m) template skylight width/depth (min 0.4m)
+  #
+  # @return [Array<OpenStudio::Model::Space>] candidates (see logs if empty)
+  def toToplit(spaces = [], opts = {})


An option to addSkylights, yet called upon by default. This is useful when treating multiple 3rd-party models (e.g. a specific market segment), with undiagnosed geometry (i.e. flying blind). Through trial and error, these handful of sliders and rules have yielded satisfactory results during recent stress testing.

brgix · 2024-10-02T21:05:06Z

lib/osut/utils.rb

+      else
+        return mismatch("area", opts[:area], Numeric, mth, DBG, 0)
+      end
+    elsif opts.key?(:srr)


It is often preferable to precalculate a desired total skylight :area (from a building's grossRoofArea x a code-required SRR%) than relying on the :srr option directly. Once :area is determined, users may (wisely) choose to filter out technical or ancillary spaces (e.g. washrooms, corridors) as potential candidates for skylights. The value of :area would remain valid - not the :srr.

brgix · 2024-10-02T21:07:22Z

lib/osut/utils.rb


-      toitures.each { |surf| h = [h, surf.vertices.max_by(&:z).z].max }
-      plafonds.each { |surf| h = [h, surf.vertices.max_by(&:z).z].max }
+      h = hMAX - hMIN


Yikes - quite the oversight!

brgix · 2024-10-02T21:11:24Z

lib/osut/utils.rb

+        # smaller than that of its roof. A set is 'thin' if the depth of its
+        # bounded box is (too) narrow. If either is true, some geometry rules
+        # may be relaxed to maximize allocated skylight area. Neither apply to
+        # cases with skylight wells.


A roof surface's tightness and/or thinness trigger accommodations to maximize skylight allocation in challenging cases.

brgix · 2024-10-02T21:14:00Z

lib/osut/utils.rb

        set[:roof   ] = roof
        set[:space  ] = space
+        set[:m      ] = space.multiplier


A number of necessary changes have been introduced to correct the use of space multipliers (and elsewhere existing subsurface multipliers). Unfortunately no RSpec tests yet ... @todo.

brgix · 2024-10-02T21:40:04Z

lib/osut/utils.rb

+      end
+    end
+
+    # Size contraction: round 2: prioritize larger sets.


Multiple rounds of skylight area contractions (instead of a single one), towards strictly meeting a requested :srr or :area.

brgix · 2024-10-02T21:41:51Z

spec/osut_tests_spec.rb

+
+      expect(s.setSurfaceType("Floor")).to be true
+      expect(s.setVertices(s.vertices.reverse)).to be true
+    end


The antiquated plenum floor vertex sequencing starts to be an issue with more recent OpenStudio versions.

brgix · 2024-10-02T21:46:56Z

spec/osut_tests_spec.rb

+    vtx << OpenStudio::Point3d.new(-14.9024000,  2.7700, 3.658)
+    vtx << OpenStudio::Point3d.new(-14.9024000,  0.0000, 3.658)
+
+    bbx = mod1.boundedBox(vtx)


Two sequential concavities prevented OSut's fits? from detecting a bounded box located outside the actual (convoluted) surface. Now fixed, although at a cost.

brgix · 2024-10-02T21:51:17Z

spec/osut_tests_spec.rb

+    #   - a new method identifying surface cutouts amongst surface vertices
+    #   - a method to purge both leader lines and cutouts from surface vertices
+    #   - have 'getRoofs' & 'grossRoofArea' rely on the remaining outer vertices
+    #     ... @todo?


Future considerations towards better harmonizing OSut's cutouts and leader lines vs native OpenStudio/EnergyPlus methods ... @todo.

brgix · 2024-10-02T21:52:46Z

spec/osut_tests_spec.rb

+        expect(zn.volume).to be_empty
+      end
+    end
+


brgix · 2024-10-04T16:54:12Z

lib/osut/utils.rb

+  INF  = OSlg::INFO.dup   # see github.com/rd2/oslg
+  WRN  = OSlg::WARN.dup   # see github.com/rd2/oslg
+  ERR  = OSlg::ERROR.dup  # see github.com/rd2/oslg
+  FTL  = OSlg::FATAL.dup  # see github.com/rd2/oslg


This is an attempt to circumvent (often numerous) Ruby warnings related to duplication of constants. These pop up when building/using parent applications relying on gems (like TBD), which have OSut as a dependency. That's possibly 3 to 4 gems harmonizing constants, while trying to keep things concise (e.g. not having to drag module namespaces if extended). It will take a while to update/build/test larger, multi-gem applications before making a definitive decision.

brgix · 2024-10-04T16:54:54Z

spec/spec_helper.rb

@@ -8,6 +8,8 @@
  # Disable RSpec exposing methods globally on `Module` and `main`
  config.disable_monkey_patching!

+  # config.warnings = true


Sometimes useful to switch on during development.

brgix · 2024-10-10T10:57:39Z

spec/osut_tests_spec.rb

    expect(cls1.clean!).to eq(DBG)

+    # The v1.11.5 (2016) seb.osm, shipped with OpenStudio, holds (what would now
+    # be considered as deprecated) a definition of plenum floors (i.e. ceiling
+    # tiles) generating several warnings with more recent OpenStudio versions.


Harmonized with (more detailed) fixes introduced in TBD Tests.

More robust 'addSkylights' (+ dependencies)

843b0ad

brgix self-assigned this Oct 2, 2024

brgix commented Oct 2, 2024

View reviewed changes

spec/osut_tests_spec.rb

expect(zn.volume).to be_empty

end

end

Copy link

Member Author

brgix Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby constants warnings - an option to test

5be7d46

brgix commented Oct 4, 2024

View reviewed changes

Updates SEB fix tests

852aba8

brgix mentioned this pull request Oct 8, 2024

Pulls OSut v0.6.0 + SEB fixes rd2/tbd#118

Merged

brgix commented Oct 10, 2024

View reviewed changes

brgix merged commit 117c7dc into develop Oct 16, 2024
7 checks passed

brgix deleted the sky branch October 16, 2024 10:36

brgix mentioned this pull request Nov 25, 2024

Initializes nrcan_446 branch: skylights & wells NREL/openstudio-standards#1854

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More robust 'addSkylights' (+ dependencies) #20

More robust 'addSkylights' (+ dependencies) #20

brgix commented Oct 2, 2024

brgix Oct 2, 2024 •

edited

Loading

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 2, 2024

brgix Oct 4, 2024 •

edited

Loading

brgix Oct 4, 2024

brgix Oct 10, 2024

More robust 'addSkylights' (+ dependencies) #20

More robust 'addSkylights' (+ dependencies) #20

Conversation

brgix commented Oct 2, 2024

brgix Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brgix Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brgix Oct 2, 2024 •

edited

Loading

brgix Oct 4, 2024 •

edited

Loading