Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove "future" dependency #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tzok
Copy link

@tzok tzok commented Jan 20, 2025

Fixes #38

@epeisach
Copy link
Collaborator

This PR essentially removes python 2.7 from the this package. We need to discuss internally first about this.

However, some aspects were missed.
a) There should be no changes to to pybind11_2_6_3_dev1. This is a submodule pointing to pybind11's repository. However, if we drop python 2.7 and < 3.6 - then CMakeLists.txt should remove inclusion of this directory.

b) setup.py should be changed - Classifiers should not list python 2.7, and a "requires-python" should be added to indicate the minimal python version. This will ensure that people using python 2, with recent setup.py and pip will not try to install the newer version. See https://packaging.python.org/en/latest/guides/dropping-older-python-versions/

We need to continue to support python3.6 - as it is still the default python3 version in centos 7 --- which is still in use in numerous places. Earlier versions of python 3 I am no sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on future library
2 participants