Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change:
To address the validation issue created due to the potential variations in String ordering during comparison.
This PR aims to fix two tests:
REASON AND FIX:
The issue arises while serializing the {column: column types} pair, the
result
returned is not in a constant order. This is becauseresult
is a JSONObject which internally uses HashMap and doesn’t maintain order.Hive-JSON-Serde/json-serde/src/main/java/org/openx/data/jsonserde/JsonSerDe.java
Line 265 in 7a05e91
Due to this, validating the jsonStr with another string doesn’t turn out to return true.
The fix is to modify the assert statements in a way to check only the presence of the individual key-value pair and ignore the order.
REPRODUCE:
This was found by using the NonDex tool.