Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables & functions #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ppartarr
Copy link
Contributor

@ppartarr ppartarr commented Mar 12, 2021

  • max neighbourhood n size is never used
  • tpw_done & guess_list serve the same purpose, so remove tpw_done
  • estimated_ball_weight is always positive (product of probability and the size of ball)
  • function test_success_rate is never called

@ppartarr ppartarr force-pushed the refactor/remove-unused-variables branch from 862352d to cee2a03 Compare March 12, 2021 07:54
@ppartarr ppartarr changed the title Remove unused variables Remove unused variables & functions Mar 12, 2021
Neighbourhood size is never used & estimated_ball_weight is always positive (product of probability & size of ball)
@ppartarr ppartarr force-pushed the refactor/remove-unused-variables branch from cee2a03 to c70c2fc Compare March 13, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant