Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): use .nvmrc as single source for node #55

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

joanrm20
Copy link
Contributor

Hey @rbardini,

Noticed you updated node version recently and thought about updating the actions/setup-node GH action to read the node version directly from the .nvmrc file.

This will guarantee that the versions will be updated in future iterations only in a single place.

Cheers ❤️

@rbardini rbardini changed the title chore: Use nvmrc as single source for node ci(workflow): use .nvmrc as single source for node Jan 21, 2024
@rbardini
Copy link
Owner

Awesome, thanks @joanrm20! ❤️

@rbardini rbardini added the enhancement New feature or request label Jan 21, 2024
@rbardini rbardini merged commit 1960ad8 into rbardini:master Jan 21, 2024
5 checks passed
Copy link

github-actions bot commented Aug 4, 2024

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants