-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): resolve <rootDir>
to .
in coverageDirectory
#26
Conversation
@rbardini kindly review / approve the workflow run. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 7
Lines ? 71
Branches ? 0
========================================
Hits ? 71
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
<rootDir>
to .
in coverageDirectory
🎉 This issue has been resolved in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for the fix, @anlesk! This solves the default use case, but eventually we should resolve |
@rbardini, I agree. The code assumes that root directory is where config file is located, but should take other options into account. |
Jest allows root directory
<rootDir>
string token to be specified for path configurations.This fix allows this variable to be resolved into
path.dirname(configPath)
.Fixes #22