RazrabsApi now use protocol, host/scheme are private fields #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fnc12 |
fnc12
requested changes
Aug 23, 2022
| class RazrabsApi { | ||
| let scheme: String | ||
| let host: String | ||
| final class RazrabsApi: PRazrabsApi { |
| // Created by Anatoliy on 23.08.2022. | ||
| // | ||
|
|
||
| protocol PRazrabsApi { |
There was a problem hiding this comment.
я бы назвал протокол RazrabsApi, а реализацию RazrabsApiImpl. Однобуквенные сокращения это ужасно для читаемости
| let host: String | ||
| final class RazrabsApi: PRazrabsApi { | ||
| private let scheme: String | ||
| private let host: String |
|
@VAnatoliy к чему такая спешка в оборачивании API в протокол? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RazrabsApi.scheme - можно сделать константой, вряд ли будет использовано http
RazrabsApi.host - лучше вынести в билд сеттингс приложения, чтобы можно было разделить dev/stage/prod инстансы апки в дальнейшем.