Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: card story page breaking #2492

Merged
merged 4 commits into from
Jan 23, 2025
Merged

fix: card story page breaking #2492

merged 4 commits into from
Jan 23, 2025
+70 −55

Conversation

tewarig
Copy link
Contributor

@tewarig tewarig commented Jan 23, 2025

Description

removed internal card example from Card.stories.tsx

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f5f16e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@tewarig tewarig changed the title fix: card page breaking fix: card story page breaking Jan 23, 2025
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 23, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f5f16e4:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented Jan 23, 2025 •
edited
Loading

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
⬇ Code 0.606 0.605 -0.001 KB

Generated by 🚫 dangerJS against f5f16e4

@tewarig tewarig merged commit 2d14a3f into master Jan 23, 2025
12 of 14 checks passed
@tewarig tewarig deleted the fix/card-page-breaking branch January 23, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhdaware saurabhdaware saurabhdaware approved these changes

@chaitanyadeorukhkar chaitanyadeorukhkar Awaiting requested review from chaitanyadeorukhkar chaitanyadeorukhkar is a code owner

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani kamleshchandnani is a code owner

@anuraghazra anuraghazra Awaiting requested review from anuraghazra anuraghazra is a code owner

@snitin315 snitin315 Awaiting requested review from snitin315 snitin315 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tewarig @rzpcibot @saurabhdaware