[Refactor]Fix ruff rule B024: abstract-base-class-without-abstract-method(setting)

[simotw]

Why are these changes needed?

according to the abstract-base-class-without-abstract-method rule

Abstract base classes are used to define interfaces. If an abstract base class has no abstract methods or properties, you may have forgotten to add an abstract method or property to the class, or omitted an @AbstractMethod decorator.

If the class is not meant to be used as an interface, consider removing the ABC base class from the class definition.

According to the discussion below.
This PR is design to be the setting to divide the task into several small PRs.

Related issue number

#47991

Checks

• I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
• I've run scripts/format.sh to lint the changes in this PR.
• I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've added any new APIs to the API Reference. For example, if I added a
    method in Tune, I've added it in doc/source/tune/api/ under the
    corresponding .rst file.
• I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • Unit tests
  • Release tests
  • This PR is not tested :(

[aslonnie]

simply removing ABC is unlikely to be the right fix for most of these cases. The right fix is more likely to be adding @abstractmethod for methods that are abstract.

[aslonnie]

I am not very familiar with this part of the code, but these fixes are unlikely the right fix.

reading the code, it is pretty clear that this class is an interface class. the right fix is more likely to be declaring all the methods as @abstractmethod

[simotw]

Hi @aslonnie, I tried adding @abstractmethod, but the tests failed because it raises an error if child classes don't implement the method.

So, simply adding @abstractmethod to methods with NotImplementedError won't work.

That said, I understand your point about maintaining the abstract structure.

[MortalHappiness]

In this case, you should annotate all methods in TorchDeviceManager with @abstractmethod. Then, for all classes inheriting from it, such as CPUTorchDeviceManager, if any methods from TorchDeviceManager are not implemented, provide an implementation with a method body that raises NotImplementedError.

Looks like this:

class TorchDeviceManager(ABC):
    @abstractmethod
    def get_current_stream(self):
        """Get current stream on accelerators like torch.cuda.current_stream"""
        ...

class CPUTorchDeviceManager(TorchDeviceManager):
    def get_current_stream(self):
        raise NotImplementedError

[MortalHappiness]

Let's divide this PR into several smaller PRs for easier review and debugging in CI.

Refer to the Ruff settings for details:

https://docs.astral.sh/ruff/settings/#lint_per-file-ignores

[simotw]

Let's divide this PR into several smaller PRs for easier review and debugging in CI.

Refer to the Ruff settings for details:

https://docs.astral.sh/ruff/settings/#lint_per-file-ignores

Good idea.
I have updated this PR to be the setting PR.
PTAL
You can expect smaller PRs for each fix later.
Thank you!