[core][compiled graphs] Introduce with_tensor_transport API #49753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisearch42
force-pushed
the
type_hint
branch
from
fdb34bc to
7e4aedd
Compare
ruisearch42
changed the title
ruisearch42
force-pushed
the
type_hint
branch
from
ed4fc79 to
9be5af0
Compare
ruisearch42
force-pushed
the
type_hint
branch
from
e8970ef to
8df83b3
Compare
ruisearch42
changed the title
ruisearch42
force-pushed
the
type_hint
branch
2 times, most recently
from
ad44154 to
99eb84b
Compare
kevin85421
reviewed
Jan 22, 2025
kevin85421
approved these changes
Jan 22, 2025
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
ruisearch42
force-pushed
the
type_hint
branch
from
b419d13 to
16750da
Compare
win5923
pushed a commit
to win5923/ray
that referenced
this pull request
Jan 23, 2025
…ect#49753) Signed-off-by: Rui Qiao <[email protected]>
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Jan 23, 2025
…ect#49753) Signed-off-by: Rui Qiao <[email protected]>
anson627
pushed a commit
to anson627/ray
that referenced
this pull request
Jan 31, 2025
…ect#49753) Signed-off-by: Rui Qiao <[email protected]> Signed-off-by: Anson Qian <[email protected]>
anson627
pushed a commit
to anson627/ray
that referenced
this pull request
Jan 31, 2025
…ect#49753) Signed-off-by: Rui Qiao <[email protected]> Signed-off-by: Anson Qian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently to specify a torch tensor transport, we use
with_type_hint(TorchTensorType(transport="nccl"|"auto"|Communicator))API, which is a bit verbose and non-intuitive.This PR introduces a new
with_tensor_transport()API to replace the oldwith_type_hint()API.It also supports an "auto" option for the "transport" arg to automatically decide whether to use shared memory, intra-process channel or NCCL as the transport, based on the node location and GPU assignments of the reader and writer actors.
Related issue number
Closes #47258
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.