[core] Simplify log directory for C++ logging #49407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/simplify-log-dir
branch
2 times, most recently
from
9ce1b12 to
9f36a13
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/simplify-log-dir
branch
from
9f36a13 to
66fcd4e
Compare
rynewang
approved these changes
Dec 23, 2024
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
|
@rynewang Could you please help me merge the PR? Thanks! |
srinathk10
pushed a commit
that referenced
this pull request
Jan 3, 2025
Followup PR for #48952 This is cleans up TODO items left in prev one, which merges `log_dir` and `log_filepath` into one. --------- Signed-off-by: dentiny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR for #48952
This is cleans up TODO items left in prev one, which merges
log_dirandlog_filepathinto one.