[data] add column relaxation #49221
Merged
[data] add column relaxation #49221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ivanthewebber , this change looks good. Could you make sure the DCO is fixed and check the CI fails? |
richardliaw
reviewed
Dec 12, 2024
python/ray/data/tests/test_map.py
Outdated
| ) | ||
| assert ds.take(2) == [{"id": 1}, {"id": 2}] | ||
|
|
||
| ds = ray.data.range(5).add_column( |
There was a problem hiding this comment.
leave a comment here to capture intent?
richardliaw
approved these changes
Dec 12, 2024
ivanthewebber
force-pushed
the
ivwebber/fix-add-column
branch
from
4c5fe83 to
67a29c9
Compare
ray-project#49114 Signed-off-by: Ivan Webber <[email protected]> Signed-off-by: Ivan Webber <[email protected]>
Signed-off-by: Ivan Webber <[email protected]> Signed-off-by: Ivan Webber <[email protected]>
Signed-off-by: Ivan Webber <[email protected]> Signed-off-by: Ivan Webber <[email protected]>
ivanthewebber
force-pushed
the
ivwebber/fix-add-column
branch
from
67a29c9 to
053bc14
Compare
|
Lint is failing? |
Signed-off-by: Ivan Webber <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
## Why are these changes needed? Aligns `ray.data.Dataset.add_column` to it's docstring and allows more flexibility for adding columns to pandas dataframes. ## Related issue number Closes ray-project#49114 ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [x] Unit test - [ ] Release tests - [ ] This PR is not tested :( `python -m pytest -v -s python\ray\data\tests\test_map.py::test_add_column` --------- Signed-off-by: Ivan Webber <[email protected]> Signed-off-by: Ivan Webber <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Aligns
ray.data.Dataset.add_columnto it's docstring and allows more flexibility for adding columns to pandas dataframes.Related issue number
Closes #49114
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.python -m pytest -v -s python\ray\data\tests\test_map.py::test_add_column