[KubeRay] Add instructions to run distributed Ray Debugger in KubeRay #49116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
approved these changes
Dec 6, 2024
| name: ssd | ||
|
|
||
|
|
||
| to the `ray-head` container and make sure sshd is running in the `ray-head` container. You can then connect VS Code to the cluster by running |
There was a problem hiding this comment.
make sure sshd is running in the
ray-headcontainer
The wording may not be very precise. Setting the container port does not start the SSHD service. Instead, the KubeRay operator configures the Kubernetes Service based on the head Pod's port configuration, allowing you to use the Kubernetes Service to access the port instead of directly accessing the head Pod.
ref: https://faun.pub/should-i-configure-the-ports-in-kubernetes-deployment-c6b3817e495
There was a problem hiding this comment.
Thanks -- I added some more instructions now that should it make very clear for people that they actually need to run sshd in the container :)
angelinalg
approved these changes
Dec 9, 2024
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
…ray-project#49116) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This addresses ray-project#45541 and ray-project#49014 ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Philipp Moritz <[email protected]> Co-authored-by: angelinalg <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This addresses #45541 and #49014
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.