[core] [7/N] Cleanup gcs server shared pointer #49089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
commented
Dec 5, 2024
| @@ -231,7 +231,7 @@ class GcsServer { | |||
| /// The cluster resource scheduler. | |||
| std::shared_ptr<ClusterResourceScheduler> cluster_resource_scheduler_; | |||
| /// The cluster task manager. | |||
| std::shared_ptr<ClusterTaskManager> cluster_task_manager_; | |||
| std::unique_ptr<ClusterTaskManager> cluster_task_manager_; | |||
There was a problem hiding this comment.
Cluster task manager depends on cluster resource manager, so defined later.
dentiny
force-pushed
the
hjiang/gcs-server-shared-pointer-7
branch
from
156e222 to
75a48f9
Compare
dentiny
commented
Dec 5, 2024
| std::shared_ptr<ClusterTaskManager> cluster_task_manager_; | ||
| std::unique_ptr<ClusterTaskManager> cluster_task_manager_; | ||
| /// The gcs resource manager. | ||
| std::unique_ptr<GcsResourceManager> gcs_resource_manager_; |
There was a problem hiding this comment.
resource manager depends on cluster resource manager, so defined later.
There was a problem hiding this comment.
Can you change those into comments. I'm still worried people will move things around without realizing there is order requirements.
dentiny
changed the title
Signed-off-by: hjiang <[email protected]>
dentiny
force-pushed
the
hjiang/gcs-server-shared-pointer-7
branch
from
75a48f9 to
ef27439
Compare
jjyao
approved these changes
Dec 5, 2024
| std::shared_ptr<ClusterTaskManager> cluster_task_manager_; | ||
| std::unique_ptr<ClusterTaskManager> cluster_task_manager_; | ||
| /// The gcs resource manager. | ||
| std::unique_ptr<GcsResourceManager> gcs_resource_manager_; |
There was a problem hiding this comment.
Can you change those into comments. I'm still worried people will move things around without realizing there is order requirements.
Signed-off-by: hjiang <[email protected]>
Signed-off-by: hjiang <[email protected]>
rynewang
approved these changes
Dec 6, 2024
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
Cleanup shared pointer and use unique pointer for clear memory ownership and less error prune. --------- Signed-off-by: hjiang <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup shared pointer and use unique pointer for clear memory ownership and less error prune.
Previous PRs: