[Data] Clarify schema validation error #48882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
scottjlee,
raulchen,
stephanie-wang,
omatthew98,
alexeykudinkin and
srinathk10
as code owners
bveeramani
changed the title
Comment on lines
-84
to
-85
| "The column '{}' does not exist in the " | ||
| "schema '{}'.".format(column, schema) |
There was a problem hiding this comment.
I think it's better to print full schema (though fixing the formatting)
There was a problem hiding this comment.
@alexeykudinkin how would I fix the formatting?
I think it still looks a bit weird even if we move the schema to a newline:
ValueError: You specified the column 'does_not_exist', but there's no such column in the dataset. The dataset has schema:
Column Type
------ ----
id int64
There was a problem hiding this comment.
Fair enough, it will look fine when printed but when embedded it's gonna look messy.
Let's keep just the list of cols
Signed-off-by: Balaji Veeramani <[email protected]>
alexeykudinkin
approved these changes
Nov 25, 2024
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
jecsand838
pushed a commit
to jecsand838/ray
that referenced
this pull request
Dec 4, 2024
```python
ray.data.range(1).groupby("does_not_exist").count().materialize()
```
**Before**
```
ValueError: The column 'does_not_exist' does not exist in the schema 'Column Type
------ ----
id int64'.
```
**After**
```
ValueError: You specified the column 'does_not_exist', but there's no such column in the dataset. The dataset has columns: {'id'}
```
---------
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Connor Sanders <[email protected]>
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
```python
ray.data.range(1).groupby("does_not_exist").count().materialize()
```
**Before**
```
ValueError: The column 'does_not_exist' does not exist in the schema 'Column Type
------ ----
id int64'.
```
**After**
```
ValueError: You specified the column 'does_not_exist', but there's no such column in the dataset. The dataset has columns: {'id'}
```
---------
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: hjiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Before
After
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.