Pass logging_config to controller global logger #48790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mimi Liao <[email protected]>
jecsand838
pushed a commit
to jecsand838/ray
that referenced
this pull request
Dec 4, 2024
## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> Currently in serve.run the logging_config is not passed to controller. This PR add this arguments into the function call so the logging_config can be correctly specified for system-level logging. ## Related issue number Closes ray-project#48652 <!-- For example: "Closes ray-project#1234" --> ### Example ``` logging_config = {"log_level": "DEBUG", "logs_dir": "./mimi_debug"} handle: DeploymentHandle = serve.run(app, logging_config=logging_config) ``` ### Before controller logs aren't saved in the specified logs_dir <img width="326" alt="image" src="https://github.com/user-attachments/assets/0d316428-e7a7-48e0-8d9d-1692a3045a4a"> ### After controller logs are correctly configured <img width="325" alt="image" src="https://github.com/user-attachments/assets/e05aba0b-75cd-4cd4-9a92-4ef8cdd84cce"> Signed-off-by: Mimi Liao <[email protected]> Signed-off-by: Connor Sanders <[email protected]>
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> Currently in serve.run the logging_config is not passed to controller. This PR add this arguments into the function call so the logging_config can be correctly specified for system-level logging. ## Related issue number Closes ray-project#48652 <!-- For example: "Closes ray-project#1234" --> ### Example ``` logging_config = {"log_level": "DEBUG", "logs_dir": "./mimi_debug"} handle: DeploymentHandle = serve.run(app, logging_config=logging_config) ``` ### Before controller logs aren't saved in the specified logs_dir <img width="326" alt="image" src="https://github.com/user-attachments/assets/0d316428-e7a7-48e0-8d9d-1692a3045a4a"> ### After controller logs are correctly configured <img width="325" alt="image" src="https://github.com/user-attachments/assets/e05aba0b-75cd-4cd4-9a92-4ef8cdd84cce"> Signed-off-by: Mimi Liao <[email protected]> Signed-off-by: hjiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently in serve.run the logging_config is not passed to controller. This PR add this arguments into the function call so the logging_config can be correctly specified for system-level logging.
Related issue number
Closes #48652
Example
Before
controller logs aren't saved in the specified logs_dir
After
controller logs are correctly configured
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.