[data] webdataset - expand JSON objects into individual samples #48673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-ju
requested review from
scottjlee,
bveeramani,
raulchen,
stephanie-wang,
omatthew98,
alexeykudinkin and
srinathk10
as code owners
Jay-ju
force-pushed
the
webdataset_json_expand
branch
from
0159ba0 to
74c3e17
Compare
richardliaw
changed the title
richardliaw
reviewed
Nov 30, 2024
| @@ -342,6 +344,8 @@ def _read_stream(self, stream: "pyarrow.NativeFile", path: str): | |||
| Yields: | |||
| List[Dict[str, Any]]: List of sample (list of length 1). | |||
| """ | |||
| import json | |||
There was a problem hiding this comment.
I think you can just import at top-level
|
Missing tests - @Jay-ju could you please add a test? |
Jay-ju
force-pushed
the
webdataset_json_expand
branch
2 times, most recently
from
bbcd0ba to
042df0b
Compare
richardliaw
requested changes
Dec 3, 2024
| @@ -362,4 +362,17 @@ def get_tar_file_iterator(): | |||
| for sample in samples: | |||
| if self.decoder is not None: | |||
| sample = _apply_list(self.decoder, sample, default=_default_decoder) | |||
| if self.expand_json: | |||
There was a problem hiding this comment.
will this always have json field?
There was a problem hiding this comment.
Yes. For example, a sample of the JSON column in WebDataset is as follows:
{
"file_name": "00001.jpg",
"height":50
}, Ultimately, it will be formed into something like this:
| file_name | height | json |
|---|---|---|
| 00001.jpg | 50 | {"file_name": "00001.jpg","height":50} |
| elif isinstance(sample["json"], dict): | ||
| parsed_json = sample["json"] | ||
| else: | ||
| raise TypeError("Unsupported data type for sample['json']") |
There was a problem hiding this comment.
can you also print what is the type you got, and the object?
Jay-ju
force-pushed
the
webdataset_json_expand
branch
3 times, most recently
from
f863a14 to
bcc0409
Compare
richardliaw
approved these changes
Dec 5, 2024
|
tests failing? |
Jay-ju
force-pushed
the
webdataset_json_expand
branch
from
737d3c1 to
7211a6f
Compare
Signed-off-by: jukejian <[email protected]>
Jay-ju
force-pushed
the
webdataset_json_expand
branch
from
f68d0e8 to
77b7a6e
Compare
The failed test cases have been completed. Could you please help merge them? |
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Dec 12, 2024
…project#48673) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: jukejian <[email protected]> Co-authored-by: srinathk10 <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
…project#48673) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: jukejian <[email protected]> Co-authored-by: srinathk10 <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.