Address comment: possible nullptr in RedisRequestContext

Closes: #47419 Signed-off-by: Chi-Sheng Liu <[email protected]>
ray-project · Dec 17, 2024 · 9779e4c · 9779e4c
1 parent 3cb06a0
commit 9779e4c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/ray/gcs/redis_context.cc b/src/ray/gcs/redis_context.cc
@@ -788,12 +788,6 @@ std::unique_ptr<CallbackReply> RedisContext::RunArgvSync(
 
 void RedisContext::RunArgvAsync(std::vector<std::string> args,
                                 RedisCallback redis_callback) {
-  // redis_async_context_ is nullptr means the connection is lost because it is reset in
-  // the disconnect callback. If the connection is lost, we need to reconnect before
-  // sending the request.
-  if (redis_async_context_ == nullptr) {
-    RAY_CHECK_OK(this->Reconnect());
-  }
   auto request_context = new RedisRequestContext(
       io_service_, std::move(redis_callback), *this, std::move(args));
   // RedisRequestContext is thread safe.

diff --git a/src/ray/gcs/redis_context.h b/src/ray/gcs/redis_context.h
@@ -171,7 +171,12 @@ class RedisContext {
   }
 
   RedisAsyncContext &async_context() {
-    RAY_CHECK(redis_async_context_);
+    // redis_async_context_ is nullptr means the connection is lost because it is reset in
+    // the disconnect callback. If the connection is lost, we need to reconnect before
+    // sending the request.
+    if (redis_async_context_ == nullptr) {
+      RAY_CHECK_OK(this->Reconnect());
+    }
     return *redis_async_context_;
   }