Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use np.logical_or.reduce for generating diffs over more than 2 partitioning arrays #53

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

sjperkins
Copy link
Member

@sjperkins sjperkins commented Jan 24, 2025

Thanks for contributing to xarray-ms.

We would appreciate it if you could add:

  • Test Cases covering your PR.
  • Documentation.
  • A Changelog entry in doc/source/changelog.rst.

📚 Documentation preview 📚: https://xarray-ms--53.org.readthedocs.build/en/53/

@sjperkins sjperkins changed the title Use np.logical_or.reduce for reducing over more than 2 partitioning arrays Use np.logical_or.reduce for generating diffs over more than 2 partitioning arrays Jan 24, 2025
@sjperkins sjperkins merged commit 4f4a79c into main Jan 24, 2025
1 check passed
@sjperkins sjperkins deleted the fix-partitioning-bug branch January 24, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant