Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cherryusb): add cherryusb library #2212

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sakumisu
Copy link

Support usb device and host with cherryusb. Also host hub supports.

1

2

@lurch
Copy link
Contributor

lurch commented Jan 27, 2025

Stupid question 1: Why does this modify the linker files in src/rp2_common/pico_crt0/rp2040/ but not those in src/rp2_common/pico_crt0/rp2350/ ?

Stupid question 2: Can this be used as a complete replacement for TinyUSB? (or would that require a much larger refactoring of the SDK's existing USB code?)

@sakumisu
Copy link
Author

Stupid question 1: Why does this modify the linker files in src/rp2_common/pico_crt0/rp2040/ but not those in src/rp2_common/pico_crt0/rp2350/ ?

Stupid question 2: Can this be used as a complete replacement for TinyUSB? (or would that require a much larger refactoring of the SDK's existing USB code?)

1, my mistake, fixed
2, Our transfer api only has write & read and no need loop, it is easy to refactor.

@sakumisu
Copy link
Author

Could you list or point out which usb code? I can help to match with cherryusb.

@lurch
Copy link
Contributor

lurch commented Jan 27, 2025

Could you list or point out which usb code? I can help to match with cherryusb.

I did a git grep -i tinyusb and it looks like apart from the src/rp2_common/tinyusb/ directory, tinyusb is only used in src/rp2_common/pico_stdio_usb/ (so perhaps not as much refactoring as I previously thought).

@lurch lurch added pico_stdio_usb port issues or discussions of porting code/libraries to rp2040 labels Jan 27, 2025
@kilograham kilograham added this to the 2.2.0 milestone Jan 29, 2025
@sakumisu sakumisu force-pushed the master branch 2 times, most recently from a3b8377 to 50f3ab7 Compare February 5, 2025 14:49
@sakumisu
Copy link
Author

sakumisu commented Feb 6, 2025

Could you list or point out which usb code? I can help to match with cherryusb.

I did a git grep -i tinyusb and it looks like apart from the src/rp2_common/tinyusb/ directory, tinyusb is only used in src/rp2_common/pico_stdio_usb/ (so perhaps not as much refactoring as I previously thought).

done

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pico_stdio_usb port issues or discussions of porting code/libraries to rp2040
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants