Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drm: rp1: rp1-dpi: Add "rgb_order" property (to match VC4 DPI) #6597

Draft
wants to merge 1 commit into
base: rpi-6.6.y
Choose a base branch
from

Conversation

njhollinghurst
Copy link
Contributor

As on VC4, the OF property overrides the order implied by media bus format. Only 4 of the 6 possible orders are supported. New add-on hardware designs should not rely on this "legacy" feature.

This is is an attempt to deal with #6505.

Not all combinations of DRM pixel format, bus format and rgb_order have been tested yet.

As on VC4, the OF property overrides the order implied by media
bus format. Only 4 of the 6 possible orders are supported. New
add-on hardware designs should not rely on this "legacy" feature.

Signed-off-by: Nick Hollinghurst <[email protected]>
@njhollinghurst njhollinghurst requested a review from 6by9 January 10, 2025 10:14
@njhollinghurst
Copy link
Contributor Author

I think this is correct, my only reticence (and the reason it's still a draft) is code size.
There might well be a smaller or cleaner way to achieve the permutation of input (shift,mask,scaling).
Alternatively, if we drop GRB, BRG support for RGB565_1X16, RGB666_1X18 there might be a simpler version that permutes output shifts (though BGR666 will still need asymmetrical settings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant