serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND #6540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 068d35a upstream. When specifying flag SER_RS485_RTS_ON_SEND in RS485 configuration, we get the following warning after commit 4afeced ("serial: core: fix sanitizing check for RTS settings"): invalid RTS setting, using RTS_AFTER_SEND instead This results in SER_RS485_RTS_AFTER_SEND being set and the driver always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which breaks some hardware using these chips. The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, so fix this by announcing support for RTS_ON_SEND. Signed-off-by: Hugo Villeneuve <[email protected]> Suggested-by: Konstantin Pugin <[email protected]> Link: https://lore.kernel.org/lkml/[email protected] Reviewed-by: Andy Shevchenko <[email protected]> Tested-by: Hugo Villeneuve <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
popcornmix
approved these changes
Dec 16, 2024
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 16, 2024
kernel: RP1 DPI: Add interlaced modes See: raspberrypi/linux#6529 kernel: ASoC: allo-piano-dac-plus: Fix volume limit locking See: raspberrypi/linux#6532 kernel: drm: vc4: txp: Do not allow 24bpp formats when transposing See: raspberrypi/linux#6533 kernel: ASoC: allo-piano-dac-plus: Suppress -517 errors See: raspberrypi/linux#6534 kernel: drm: rp1: rp1-dpi: Fix optional dependency on RP1_PIO See: raspberrypi/linux#6535 kernel: serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND See: raspberrypi/linux#6540
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Dec 16, 2024
kernel: RP1 DPI: Add interlaced modes See: raspberrypi/linux#6529 kernel: ASoC: allo-piano-dac-plus: Fix volume limit locking See: raspberrypi/linux#6532 kernel: drm: vc4: txp: Do not allow 24bpp formats when transposing See: raspberrypi/linux#6533 kernel: ASoC: allo-piano-dac-plus: Suppress -517 errors See: raspberrypi/linux#6534 kernel: drm: rp1: rp1-dpi: Fix optional dependency on RP1_PIO See: raspberrypi/linux#6535 kernel: serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND See: raspberrypi/linux#6540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 068d35a upstream.
When specifying flag SER_RS485_RTS_ON_SEND in RS485 configuration, we get the following warning after commit 4afeced ("serial: core: fix sanitizing check for RTS settings"):
This results in SER_RS485_RTS_AFTER_SEND being set and the driver always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which breaks some hardware using these chips.
The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, so fix this by announcing support for RTS_ON_SEND.
Suggested-by: Konstantin Pugin [email protected]
Link: https://lore.kernel.org/lkml/[email protected]
Reviewed-by: Andy Shevchenko [email protected]
Tested-by: Hugo Villeneuve [email protected]
Link: https://lore.kernel.org/r/[email protected]