Prevent loops from continuing after succeeding once

Co-authored-by: Lawrence Mitchell <[email protected]>
rapidsai · Nov 16, 2023 · 68aef08 · 68aef08
1 parent 5bda348
commit 68aef08
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cpp/src/endpoint.cpp b/cpp/src/endpoint.cpp
@@ -162,7 +162,7 @@ void Endpoint::close(uint64_t period, uint64_t maxAttempts)
 
   if (worker->isProgressThreadRunning()) {
     bool closeSuccess = false;
-    for (uint64_t i = 0; i < maxAttempts; ++i) {
+    for (uint64_t i = 0; i < maxAttempts && !closeSuccess; ++i) {
       utils::CallbackNotifier callbackNotifierPre{};
       worker->registerGenericPre([this, &callbackNotifierPre, &status, closeMode]() {
         status = ucp_ep_close_nb(_handle, closeMode);
@@ -277,7 +277,7 @@ size_t Endpoint::cancelInflightRequests(uint64_t period, uint64_t maxAttempts)
     worker->progress();
   } else if (worker->isProgressThreadRunning()) {
     bool cancelSuccess = false;
-    for (uint64_t i = 0; i < maxAttempts; ++i) {
+    for (uint64_t i = 0; i < maxAttempts && !cancelSuccess; ++i) {
       utils::CallbackNotifier callbackNotifierPre{};
       worker->registerGenericPre([this, &callbackNotifierPre, &canceled]() {
         canceled = _inflightRequests->cancelAll();

diff --git a/cpp/src/worker.cpp b/cpp/src/worker.cpp
@@ -414,7 +414,7 @@ size_t Worker::cancelInflightRequests(uint64_t period, uint64_t maxAttempts)
     progressPending();
   } else if (isProgressThreadRunning()) {
     bool cancelSuccess = false;
-    for (uint64_t i = 0; i < maxAttempts; ++i) {
+    for (uint64_t i = 0; i < maxAttempts && !cancelSuccess; ++i) {
       utils::CallbackNotifier callbackNotifierPre{};
       registerGenericPre([&callbackNotifierPre, &canceled, &inflightRequestsToCancel]() {
         canceled = inflightRequestsToCancel->cancelAll();