-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added notebook for sentiment analysis #35
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cc @VibhuJawa |
View / edit / reply to this conversation on ReviewNB VibhuJawa commented on 2021-09-01T23:16:11Z Line #1. !pip install hvplot Might be worth commenting this out to keep the notebook clean in a run. Also worth adding Line #3. !!pip install s3fs
|
View / edit / reply to this conversation on ReviewNB VibhuJawa commented on 2021-09-01T23:16:11Z This code adds complexity.
I suggest switching to below, Its much faster and only uses cudf . Also might be useful to switch to below, it only takes 30 seconds.
%%time input_bucket = 's3://amazon-reviews-pds' input_path = '/parquet/product_category=Office_Products/*.parquet' |
View / edit / reply to this conversation on ReviewNB VibhuJawa commented on 2021-09-01T23:16:12Z Add a markdown section explaing that you are merging reviews here. |
View / edit / reply to this conversation on ReviewNB VibhuJawa commented on 2021-09-01T23:16:13Z Add a section here explaining that you are gonna be tokenizing here. |
View / edit / reply to this conversation on ReviewNB VibhuJawa commented on 2021-09-01T23:16:13Z Add a section to say you are starting a Data Loader |
View / edit / reply to this conversation on ReviewNB VibhuJawa commented on 2021-09-01T23:16:14Z Line #2. from transformers import BertModel Mark Down section explaining that you are creating a model here. |
View / edit / reply to this conversation on ReviewNB VibhuJawa commented on 2021-09-01T23:16:14Z Line #3. def train_model(model, data_loader, loss_fn, optimizer, scheduler, n_examples): Add a markdown section explaining training loop. . |
View / edit / reply to this conversation on ReviewNB VibhuJawa commented on 2021-09-01T23:16:15Z Line #1. ## Use some custom examples Add a markdown section with custom examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vinaybagade . Thanks a lot for working on this. The example is really useful across board.
I have requested some changes which you can view here.
No description provided.