dask 2025.1.0 compatability #79
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows the changes in dask/dataframe/accessor.py after https://github.com/dask/dask/pull/11606/files#diff-02020cca578450d377d1f45564123cfae3647b7f4435c55cd6b5ac41f1af2225
TomAugspurger
force-pushed
the
tom/fix/dask-2025.1-compat
branch
from
2664652 to
632166e
Compare
TomAugspurger
commented
Jan 21, 2025
| @@ -12,9 +12,9 @@ name = "rapids-dask-dependency" | |||
| version = "25.02.00a0" | |||
| description = "Dask and Distributed version pinning for RAPIDS" | |||
| dependencies = [ | |||
| "dask==2024.12.1", | |||
There was a problem hiding this comment.
I tried briefly to support dask>=2025.12.1. It'd be relatively easy at the code level, by putting the imports and Accessor definition behind a Dask version check.
The packaging side is a bit tricker. dask-expr is pinned tightly to dask==2024.12.1: https://github.com/dask/dask-expr/blob/42e7a8958ba286a4c7b2f199d143a70b0b479489/pyproject.toml#L29C6-L29C23. Including dask-expr as a dependency will force the solver to pick 2024.12.1.
We could maybe resolve this with a new release of dask-expr that relaxes that pin and then depend on that. But I'm not sure how valuable this is, so I won't chase it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the changes in dask/dataframe/accessor.py after https://github.com/dask/dask/pull/11606/files#diff-02020cca578450d377d1f45564123cfae3647b7f4435c55cd6b5ac41f1af2225
Closes #78
Edit: I'll get my commits signed and re-push.