Skip to content

Commit

Permalink
update thresholds
Browse files Browse the repository at this point in the history
  • Loading branch information
jameslamb committed Dec 18, 2024
1 parent 6bf5eba commit 9783244
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 24 deletions.
18 changes: 3 additions & 15 deletions ci/validate_wheel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,18 @@ package_name=$3
RAPIDS_CUDA_MAJOR="${RAPIDS_CUDA_VERSION%%.*}"

# some packages are much larger on CUDA 11 than on CUDA 12
# TODO(jameslamb): adjust these thresholds
if [[ "${package_name}" == "libraft" ]]; then
if [[ "${RAPIDS_CUDA_MAJOR}" == "11" ]]; then
PYDISTCHECK_ARGS=(
--max-allowed-size-compressed '5.0G'
--max-allowed-size-compressed '750M'
)
else
PYDISTCHECK_ARGS=(
--max-allowed-size-compressed '5.0G'
)
fi
elif [[ "${package_name}" == "pylibraft" ]] || [[ "${package_name}" == "raft-dask" ]]; then
if [[ "${RAPIDS_CUDA_MAJOR}" == "11" ]]; then
PYDISTCHECK_ARGS=(
--max-allowed-size-compressed '600M'
)
else
PYDISTCHECK_ARGS=(
--max-allowed-size-compressed '400M'
--max-allowed-size-compressed '100M'
)
fi
else
echo "Unsupported package name: ${package_name}"
exit 1
PYDISTCHECK_ARGS=()
fi

cd "${package_dir}"
Expand Down
6 changes: 2 additions & 4 deletions python/libraft/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,10 @@ project(

option(USE_CUDA_MATH_WHEELS "Use the CUDA math wheels instead of the system libraries" OFF)

# Check if raft is already available. If so, it is the user's responsibility to ensure that the
# CMake package is also available at build time of the Python raft package.

find_package(CUDAToolkit REQUIRED)

# TODO(jameslamb): make this work
# Check if raft is already available. If so, it is the user's responsibility to ensure that the
# CMake package is also available at build time of the Python raft package.
find_package(raft "${RAPIDS_VERSION}")

if(raft_FOUND)
Expand Down
1 change: 0 additions & 1 deletion python/libraft/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,5 @@ matrix-entry = "cuda_suffixed=true;use_cuda_wheels=true"
[tool.pydistcheck]
select = [
# NOTE: size threshold is managed via CLI args in CI scripts
# TODO(jameslamb): adjust this
"distro-too-large-compressed",
]
5 changes: 3 additions & 2 deletions python/pylibraft/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,12 @@ matrix-entry = "cuda_suffixed=true"

[tool.pydistcheck]
select = [
# NOTE: size threshold is managed via CLI args in CI scripts
# TODO(jameslamb): adjust this
"distro-too-large-compressed",
]

# PyPI limit is 100 MiB, fail CI before we get too close to that
max_allowed_size_compressed = '75M'

[tool.pytest.ini_options]
filterwarnings = [
"error",
Expand Down
2 changes: 0 additions & 2 deletions python/raft-dask/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ authors = [
]
license = { text = "Apache 2.0" }
requires-python = ">=3.10"
# TODO(jameslamb): does this really need joblib and numba?
dependencies = [
"dask-cuda==25.2.*,>=0.0.0a0",
"distributed-ucxx==0.42.*,>=0.0.0a0",
Expand Down Expand Up @@ -136,5 +135,4 @@ select = [
]

# detect when package size grows significantly
# TODO(jameslamb): adjust this
max_allowed_size_compressed = '300M'

0 comments on commit 9783244

Please sign in to comment.