Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ucx-proc dependency #109

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#142

ucx-proc has been unnecessary since UCX 1.14, and RAPIDS minimum supported UCX version is 1.15. This proposes dropping it from environments here.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 24, 2025
@jameslamb jameslamb requested review from a team as code owners January 24, 2025 17:08
@jameslamb jameslamb requested review from gforsyth and removed request for a team January 24, 2025 17:08
Copy link

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I guess this repo only builds on push to main?

@jameslamb
Copy link
Member Author

I guess this repo only builds on push to main?

Right now it doesn't have any CI enabled. Look at https://github.com/rapidsai/dask-build-environment/actions

Screenshot 2025-01-27 at 9 41 10 AM

It was recently stopped as part of some ongoing work re-organizing how, where, and when Dask's GPU tests are run.

So I don't think this PR will affect anything right now, but this cleanup should still be safe.

@jameslamb jameslamb merged commit c464176 into rapidsai:main Jan 27, 2025
@jameslamb jameslamb deleted the remove-ucx-proc branch January 27, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants