Skip to content

Commit

Permalink
Fix/external tests (#621)
Browse files Browse the repository at this point in the history
This PR aims to fix the [unbound input variable](https://github.com/rapidsai/cuxfilter/actions/runs/10402536485/job/28807203732#step:9:734) issue when running the external testing workflow

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #621
  • Loading branch information
AjayThorve authored Aug 16, 2024
1 parent 76fc52e commit a00bf9d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
14 changes: 9 additions & 5 deletions ci/test_external.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,14 @@ set -u
rapids-print-env

# Define input parameter
PROJECT=$1
PR_NUMBER=$2
PROJECT="${1:-all}"
PR_NUMBER="${2:-0}"
LIBRARIES=("datashader" "holoviews")

# set conda env variable NUMBA_CUDA_LOW_OCCUPANCY_WARNINGS to 0
# to suppress low occupancy warnings
export NUMBA_CUDA_LOW_OCCUPANCY_WARNINGS=0

# Change directory to /tmp
pushd /tmp

Expand Down Expand Up @@ -61,7 +65,7 @@ else
git clone https://github.com/pyviz/$PROJECT.git

# Check if PR_NUMBER is a non-empty, valid number
if [ -n "$PR_NUMBER" ] && [ "$PR_NUMBER" -eq "$PR_NUMBER" ] 2>/dev/null; then
if [ "$PR_NUMBER" -ne 0 ] && [ "$PR_NUMBER" -eq "$PR_NUMBER" ] 2>/dev/null; then
rapids-logger "checkout PR $PR_NUMBER"
# Fetch the pull request and check it out
git fetch origin pull/$PR_NUMBER/head:pr/$PR_NUMBER
Expand All @@ -75,9 +79,9 @@ else
python -m pip install .[tests]


rapids-logger "Run GPU tests for $LIBRARY"
rapids-logger "Run GPU tests for $PROJECT"

python -m pytest $LIBRARY/tests/ --numprocesses=8 --dist=worksteal --gpu
python -m pytest $PROJECT/tests/ --numprocesses=8 --dist=worksteal --gpu

popd
fi
Expand Down
5 changes: 0 additions & 5 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,5 @@ dependencies:
- *dask_cudf_unsuffixed
- cuxfilter==24.10.*,>=0.0.0a0
- python>=3.9,<3.12
- xarray-spatial
- pycaret
- graphistry
- dash
- dask-sql
- pytest-benchmark
- pytest-xdist

0 comments on commit a00bf9d

Please sign in to comment.