HNSW GPU hierarchy #616
Merged
HNSW GPU hierarchy #616
+261
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
feature request
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
tfeher
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks Divye for the PR! The PR looks good overall. There is one error with handling large datasets, I proposed a suggestion to fix that. With that fix I could successfully run this with large dataset that does not fit GPU mem. Apart from that I have a few smaller suggestions.
tfeher
reviewed
Feb 3, 2025
tfeher
reviewed
Feb 5, 2025
tfeher
approved these changes
Feb 5, 2025
cjnolet
approved these changes
Feb 6, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.