Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAGRA binary Hamming distance support #610

Open
wants to merge 33 commits into
base: branch-25.02
Choose a base branch
from
Open

CAGRA binary Hamming distance support #610

wants to merge 33 commits into from

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Jan 24, 2025 •
edited
Loading

This PR adds the binary Hamming distance support to CAGRA.

dependency: #612

TODO:

  • Add Hamming distance dist_op for CAGRA search
    • Add DistanceType::BinaryHamming (because HammingUnexpanded is not bitwise operation)
  • Support graph build
    • Want to use the iterative graph build method that uses the CAGRA search for graph build (anaruse@5a80659) because otherwise the binary Hamming distance support for IVFPQ or NN Descent is additionally required.
  • Add CI test
    • GT creation
    • Add test cases
  • Test on some benchmark datasets

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 24, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@enp1s0 enp1s0 self-assigned this Jan 24, 2025
@enp1s0 enp1s0 added feature request New feature or request non-breaking Introduces a non-breaking change labels Jan 24, 2025
@anaruse anaruse mentioned this pull request Jan 24, 2025
Open
@cjnolet
Copy link
Member

cjnolet commented Jan 25, 2025

/ok to test

cjnolet and others added 12 commits January 25, 2025 15:46
@cjnolet
Merge branch 'branch-25.02' into iteratively_build_graph_index
d7badb5
@enp1s0
Merge branch 'branch-25.02' into cagra-hamming-distance
851caa8
@anaruse @enp1s0
Iteratively build index using cagra search
ff755d7
@anaruse @enp1s0
Remove unused code and add comments
81f0bb0
@anaruse
Support for datasets that do not meet the alighment restriction
5e85808
@anaruse
Merge remote-tracking branch 'anaruse/iteratively_build_graph_index' …
01482d5 
…into iteratively_build_graph_index
@enp1s0
Merge branch 'iteratively_build_graph_index' into cagra-hamming-dista…
99d7ccc 
…nce-iterative-build
@enp1s0
Update str_metric
2da5a59
@anaruse
Add tests for iterative_build_graph_index
8525f29
@enp1s0
Merge branch 'iteratively_build_graph_index' into cagra-hamming-dista…
48dace3 
…nce-iterative-build
@enp1s0
Merge branch 'cagra-hamming-distance-iterative-build' of ssh://gitlab…
22c0830 
….enp1s0.dev:11022/nv/cuvs into cagra-hamming-distance-iterative-build
@enp1s0
Fix GTEST_SKIP
1d8f4f9
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 27, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@enp1s0 enp1s0 marked this pull request as ready for review January 27, 2025 17:33
@enp1s0 enp1s0 requested review from a team as code owners January 27, 2025 17:33
@cjnolet
Copy link
Member

cjnolet commented Jan 27, 2025

/ok to test

@enp1s0
Copy link
Member Author

enp1s0 commented Jan 28, 2025

@cjnolet Can you do /ok to test again?

@cjnolet
Copy link
Member

cjnolet commented Jan 28, 2025

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jan 30, 2025

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enp1s0 enp1s0

Labels
CMake cpp feature request New feature or request non-breaking Introduces a non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enp1s0 @cjnolet @anaruse