-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor CUDA versions in dependencies.yaml #1317
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-24.02
from
jameslamb:rework-dependencies
Jan 11, 2024
Merged
refactor CUDA versions in dependencies.yaml #1317
rapids-bot
merged 4 commits into
rapidsai:branch-24.02
from
jameslamb:rework-dependencies
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vyasr
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Jan 11, 2024
vyasr
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise all good.
bdice
approved these changes
Jan 11, 2024
Co-authored-by: Vyas Ramasubramani <[email protected]>
raydouglass
approved these changes
Jan 11, 2024
One job is failing, like this:
To me, that looks like the wheel download was interrupted, e.g. by some brief networking disruption. Pushed an empty commit to re-trigger CI. |
It looks like that cleared out |
/merge |
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 10, 2024
* switches to CUDA 12.2.2 for building conda packages and wheels * adds new tests running against CUDA 12.2.2 * adds some `"12.*"` globs in `dependencies.yaml` missed in #1317 ### Notes for Reviewers This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS. For more details see: * rapidsai/build-planning#7 * rapidsai/shared-workflows#166 Planning a second round of PRs to revert these references back to a proper `branch-24.{nn}` release branch of `shared-workflows` once rapidsai/shared-workflows#166 is merged. *(created with `rapids-reviser`)* Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) Approvers: - Jake Awe (https://github.com/AyodeAwe) - https://github.com/jakirkham URL: #1320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#7.
Proposes splitting the
cuda-version
dependency independencies.yaml
out to its own thing, separate from the bits of the CUDA Toolkit this project needs.Benefits of this change
cuda-version
version in environments"12.*"
)conda
recipe is missing a dependency" are caught in CIChecklist