Use cuda.bindings layout. #6233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
dantegd
approved these changes
Jan 22, 2025
jakirkham
approved these changes
Jan 22, 2025
|
A couple CI jobs were failing and this PR was a little out-of-date. Likely these are issues that have been fixed more recently. So updated the PR |
|
/merge |
|
Looks like the CUDA 11.8 wheel tests still fail. Did we find a resolution to that? |
Yes, see rapidsai/build-planning#137. The PR to RAFT rapidsai/raft#2548 fixed it. These failures are not the same. |
|
Though it looks like that was merged 2 days ago. It looked like the failure here was more recent. We have also been seeing other CI issues with cuML. Will add you to a thread |
|
Huzzah! 🎉 The last CI restart fixed it 😄 Thanks Bradley and Dante! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates cuML to use the new cuda-python
cuda.bindingslayout. See rapidsai/build-planning#117.