Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust margin of ARIMA flaky test #6227

Open
wants to merge 11 commits into
base: branch-25.02
Choose a base branch
from

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jan 16, 2025

No description provided.

@dantegd dantegd requested a review from a team as a code owner January 16, 2025 00:51
@dantegd dantegd requested review from betatim and vyasr January 16, 2025 00:51
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 16, 2025
@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Jan 16, 2025
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused why there are so many commits in this PR, but the diff is one line and all the intermediate commits will get squashed out so this seems OK to me.

@dantegd
Copy link
Member Author

dantegd commented Jan 16, 2025

I've used the same branch for all the fixes for Scipy 1.15, since we have squash commits then the PRs show all the commits I've done :)

@betatim
Copy link
Member

betatim commented Jan 16, 2025

There is also a TSNE test that just fails (assert 0.84 < 0.85). Might resolve itself with rerunning.

Fine with increasing the tolerance for arima if there is nothing else we can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants