Fix bug in MG Neighborhood sampling #4827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpp/src/c_api/neighbor_sampling.cpp
Outdated
| @@ -948,11 +948,13 @@ struct neighbor_sampling_functor : public cugraph::c_api::abstract_functor { | |||
| std::exclusive_scan( | |||
| recvcounts.begin(), recvcounts.end(), displacements.begin(), size_t{0}); | |||
|
|
|||
| (*label_to_comm_rank) | |||
| .resize(displacements.back() + recvcounts.back(), handle_.get_stream()); | |||
| rmm::device_uvector<label_t> tmp_label_to_comm_rank( | |||
There was a problem hiding this comment.
Why not just use label_to_comm_rank.resize(...) here?
There was a problem hiding this comment.
It is an optional which is initialized to std::nullopt
There was a problem hiding this comment.
label_to_comm_rank =
rmm::device_uvector<label_t>(displacements.back() + recvcounts.back(), handle_.get_stream());
is sufficient (no need to create a temporary and move).
alexbarghi-nv
added
bug
seunghwak
approved these changes
Dec 18, 2024
naimnv
approved these changes
Jan 6, 2025
…2_fix-bug-mg-nbr-sampling
jnke2016
force-pushed
the
branch-25.02_fix-bug-mg-nbr-sampling
branch
from
5a1679b to
1ca214b
Compare
seunghwak
approved these changes
Jan 6, 2025
ChuckHastings
approved these changes
Jan 6, 2025
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
Adds support for heterogeneous distributed sampling to the cuGraph distributed sampler. Prerequisite for exposing this functionality to cuGraph-PyG. Has been initially tested with cuGraph-PyG. Updates the distributed sampler to use the new sampling API. Merge after #4775, #4827, #4820 Closes #4773 Closes #4401 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) - Joseph Nke (https://github.com/jnke2016) - Ralph Liu (https://github.com/nv-rliu) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #4795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when computing the global start vertex labels