Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce libcugraph wheels #4804
introduce libcugraph wheels #4804
Changes from 69 commits
2898e78
0ecd5a5
f1645ac
6e1d3d9
3aa693c
7c55d20
c5cb53d
e73606c
fc37020
e80d566
695f627
486bf96
fce4fcf
796b54e
157f63e
4b4c4b2
e5aa3c2
089109f
881dc25
3484186
ead60e4
7dd4409
1d60712
7913278
96a7b5b
a18be8c
7f4f13b
dc7dac9
a38e5ae
3e57917
79cebbc
3a07f41
c753752
8e9fc0e
e72f55c
f924cef
c6b1d5a
ba612bd
bf8f815
1847314
740c3e9
9b0d635
4f742e5
4a9c070
2e77200
a026fc6
ffc122e
073504c
f5c8f16
f959f49
cdffb59
fbdc791
c629a4b
cce3e86
e7a2291
05e8617
8fe1d33
86c56d0
3130739
d623139
4e1265d
12a01e2
540c1a4
5573920
72978c7
5bc7523
47672c9
5b6fd89
abd6f18
96fb23a
ba73e56
2dbd946
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copied from pylibcugraph, so I want to question it a bit. Are we really limited to only 1/4 of the available cores? I am guessing it's due to memory requirements at compile time?
Can we try to be more aggressive in a follow-up PR? Or can we add comments to explain why this is so limited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, this was added back in #4489 (comment) to deal with out-of-memory issues building wheels.
Since most of the heavy compilation would move to
libcugraph
wheels in this PR, I've moved this limiting (and requesting acpu32
node) over tolibcugraph
here.HOWEVER... maybe now that these builds aren't also compiling RAFT and since #4720 reduced the number of TUs being compiled, we could get away with a higher degree of parallelism.
I'll push a change here trying to remove this limit, let's see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a changed removing this limiting of
PARALLEL_LEVEL
. I left this requesting acpu32
node for now. Let's see how it goes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To test the changes in this PR, I tested
update-version.sh
like this:ci/release/update-version.sh '25.04.00'
That revealed that this file doesn't exist any more... because all the docs were moved over to https://github.com/rapidsai/cugraph-docs in #4837
Thought it wasn't worth a new PR and CI run just for this, so just adding it here.