Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.12 into branch-25.02 #92

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Dec 6, 2024

Forward-merge triggered by push to branch-24.12 that creates a PR to keep branch-25.02 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

CUDA 11.4 is only tested in nightly CI (not on PRs) for this project.

This project doesn't support CUDA 11.4 (because the versions of PyTorch
it is compatible with don't), so #89 turned off most of those CUDA 11.4
test jobs. That worked for wheels, but conda tests need to be turned off
as well.

```text
tests/data/test_dask_graph_store.py::test_get_edge_index[multi_edge_multi_vertex_graph_1-cudf] - AssertionError: Torch not compiled with CUDA enabled
```

([build
link](https://github.com/rapidsai/cugraph-gnn/actions/runs/12198233986/job/34029537082#step:8:141493))

This skips nightly tests against CUDA 11.4.

## Notes for Reviewers

### How I tested this

Triggered a run of the nightly test job from this branch ([by clicking
"Run workflow"
here](https://github.com/rapidsai/cugraph-gnn/actions/workflows/test.yaml)),
using the latest nightly packages:

* **use workflow from:** `pull-request/91`
* **branch:** `branch-24.12`
* **date:** `2024-12-06`
* **sha:** `7ec8ace3cf7007dcca796e484f587af77d328e8f` (from
https://github.com/rapidsai/cugraph-gnn/commits/branch-24.12/)

Build link:
https://github.com/rapidsai/cugraph-gnn/actions/runs/12203424243/job/34046336319
@rapids-bot rapids-bot bot requested a review from a team as a code owner December 6, 2024 21:08
@rapids-bot rapids-bot bot requested a review from bdice December 6, 2024 21:08
Copy link
Author

rapids-bot bot commented Dec 6, 2024

FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/

IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the /merge comment). Instead, an admin must manually merge by changing the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@jameslamb
Copy link
Member

put up #95 to fix conflicts

@raydouglass raydouglass merged commit b0e0222 into branch-25.02 Dec 16, 2024
433 of 438 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants