Heterogeneous Link Prediction Example for cuGraph-PyG #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
alexbarghi-nv
added
improvement
alexbarghi-nv
commented
Jan 27, 2025
There was a problem hiding this comment.
This is only a correction to the type hints. Method behavior is unchanged.
|
Confirmed this is working on 8xH100 |
tingyu66
approved these changes
Jan 30, 2025
bdice
reviewed
Jan 31, 2025
| common: | ||
| - output_types: [conda] | ||
| packages: | ||
| - pytorch>=2.3,<2.6a0 |
There was a problem hiding this comment.
I'm a bit confused, do we also need an upper bound pinning for pip packages? It appears to be reusing *pytorch_pip below, which won't have the <2.6a0 upper bound.
KyleFromNVIDIA
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a heterogeneous link prediction example for cuGraph-PyG that uses the Taobao dataset. Loosely based on the Taobao example from the PyG repository.
Adds ability to specify fanout as a dictionary to better align with PyG API.
Fixes a bug where the number of negative samples was calculated incorrectly, causing additional unwanted negative samples to be generated.
Updates the negative sampling call to match the new behavior added in rapidsai/cugraph#4885
Merge after rapidsai/cugraph#4898