Improved onestep checkout UX #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/improved-onestep-ux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some UX improvements mainly aimed at the onestep checkout, but are also applicable to the default checkout
More in detail:
Now we send the set billing address when the billing address form has all required fields filled so no errors are logged due to missing fields.
When calling updateCart we choose the last cart we find. When running combined queries this should result in us getting the latest cart data.
Now we show a message that the shipping address is required before showing shipping methods.
(This is also the case for payment methods when it is not a virtual order, otherwise errors will be returned by GraphQL)
Additionally i've fixed the 500 errors due to rapidez-reviews missing