[3] Remove slideover from core and use blade-components slideover #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimmyHoenderdaal
requested review from
royduin and
indykoning
as code owners
JimmyHoenderdaal
changed the title
JimmyHoenderdaal
changed the title
Roene-JustBetter
approved these changes
Dec 23, 2024
jordythevulder
approved these changes
Dec 24, 2024
|
It seems like this is already merged, only the slideover needs to be removed. Please double check |
…er-blade-components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files can be removed as we use them from blade-components
and added the overflow-clip as the readme states
this should be merged first for it to fit together properly
rapidez/blade-components#13
(otherwise overflow-clip and the z-indexes won't be correct)