Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3] Add blade reviews to templates #679

Merged
merged 5 commits into from
Jan 29, 2025
Merged

[3] Add blade reviews to templates #679

merged 5 commits into from
Jan 29, 2025

Conversation

JimmyHoenderdaal
Copy link
Member

this should be merged after: rapidez/reviews#29

@JimmyHoenderdaal JimmyHoenderdaal mentioned this pull request Dec 20, 2024
Merged
@royduin
Copy link
Member

royduin commented Jan 15, 2025

  • There is a conflict
  • As this requires the latest version of rapidez/reviews we should make sure Composer knows. But.. it's not a requirement of the core; it's an optional package. I think defining a conflict is the best option here: https://getcomposer.org/doc/04-schema.md#conflict

@royduin royduin merged commit d10b528 into master Jan 29, 2025
8 of 12 checks passed
@royduin royduin deleted the feature/blade-reviews branch January 29, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royduin royduin royduin left review comments

@indykoning indykoning Awaiting requested review from indykoning indykoning is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimmyHoenderdaal @royduin