TextFit: Internal review #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random3940
commented
Aug 23, 2024
src/mbgl/sprite/sprite_parser.cpp
Outdated
| @@ -150,6 +152,36 @@ std::optional<style::ImageContent> getContent(const JSValue& value, const char* | |||
| return std::nullopt; | |||
| } | |||
|
|
|||
| std::optional<style::TextFit> parseTextFit(const std::string& value) { | |||
There was a problem hiding this comment.
Is this pattern used in other parts of ML/N for parsing values? Creating and filling static unordered_map, filling it with std::strings seems like overkill, especially given that there is only three constants to check against.
I'm interested to learn why this was chosen over simple string comparison?
random3940
commented
Aug 23, 2024
src/mbgl/sprite/sprite_parser.cpp
Outdated
| if (value.HasMember(property)) { | ||
| auto& v = value[property]; | ||
| if (v.IsString()) { | ||
| return parseTextFit(v.GetString()); |
There was a problem hiding this comment.
This would create std::string and copy underlying buffer. ML/N already uses std::string_view and I think it will be a good fit here.
random3940
commented
Aug 23, 2024
| const float boxScale, | ||
| const float padding, | ||
| const style::SymbolPlacementType placement, | ||
| IndexedSubfeature indexedFeature_, | ||
| const RefIndexedSubfeature& indexedFeature_, |
There was a problem hiding this comment.
I'm curious why this changed? "Ref" imposes some lifetime restrictions on index it's using - are those guaranteed to hold? Why TextFit changes this?
qqz003
force-pushed
the
support-textFit
branch
2 times, most recently
from
8241c81 to
1d27c79
Compare
qqz003
force-pushed
the
support-textFit
branch
from
9fb4964 to
566f9b6
Compare
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Bart Louwers <[email protected]>
for more information, see https://pre-commit.ci
qqz003
force-pushed
the
support-textFit
branch
from
b8a362f to
0874fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the liberty to open this to have an easier way to discuss the changes.