Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure go telemetry files aren't added to the commit #577

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Dec 23, 2024

Go telemetry in go 1.23 are written to $HOME/.config/go/ (or xdg config). Rancher's dapper config points $HOME to the root of the repo, so running the go generate command creates telemetry files which are then added with git add ..

Since we don't want those files in the commit, we remove them before staging the files.

@tomleb tomleb requested a review from a team as a code owner December 23, 2024 18:01
@tomleb tomleb merged commit fdb9032 into rancher:main Dec 31, 2024
2 checks passed
@tomleb tomleb deleted the webhook-ci branch December 31, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants