Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "How to modify folder to hold state" #209

Closed
wants to merge 1 commit into from

Conversation

masap
Copy link
Contributor

@masap masap commented May 16, 2024

SURE-7512.

@masap masap requested a review from a team as a code owner May 16, 2024 01:02
docs/advanced.md Outdated
```sh
sudo ln -sr /mnt/disk2/rancher /var/lib/rancher
```
We are planning to allow the default path to be modified using the `data-dir` option.
Copy link
Member

@brandond brandond May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an accurate statement. RKE2 already supports changing this path via data-dir flag; it is Ranchers provisioning framework that does not allow for changing the data-dir flag's value.

I think this docs change would be better suited for the Rancher docs, not the rke2 docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for comment. I removed notes about data-dir.

@@ -380,3 +380,9 @@ spec:
- name: NVIDIA_DRIVER_CAPABILITIES
value: all
```

## How to create symbolic link to RKE2 related directory
Copy link
Member

@brandond brandond May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still unclear on what you mean by RKE2 related directory. We don't use the term "RKE2 related directory" anywhere else in our documentation, and it sounds like you're describing how to relocate the RKE2 data-dir using a symlink instead of by changing the flag value. Can we perhaps refer to it that way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood this article should not be in RKE2 document. I will drop this.

@masap masap closed this May 17, 2024
@masap masap deleted the SURE-7512 branch May 17, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants