Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: wait for webhook to be ready downstream as well #33

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

moio
Copy link
Contributor

@moio moio commented Dec 19, 2024

Adds an extra waiting step to rancher-webhook downstream.

In some situations (tested k3d locally) the rancher-monitoring chart is installed earlier than cluster import is completed, and the webhook fails because its endpoint is not yet ready.

@moio moio requested a review from git-ival December 19, 2024 11:54
Copy link
Contributor

@git-ival git-ival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested a deployment using the typical AWS dart and everything deployed as expected.

@git-ival git-ival merged commit 3b34f54 into rancher:main Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants