feat: make aws credentials optional when s3 backup #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
force-pushed
the
backup-s3-optional-credential-keys
branch
2 times, most recently
from
b9367bb to
70372e8
Compare
alexander-demicev
approved these changes
Jan 9, 2025
anmazzotti
approved these changes
Jan 10, 2025
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
backup-s3-optional-credential-keys
branch
from
70372e8 to
ded588a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it*:
The
S3CredentialSecretfield inServerConfig.Etcd.BackupConfig.S3.S3CredentialSecretis required and limits users to authenticate with AWS access/secret keys only. Making this optional allows using assumed IAM roles instead.When setting
ServerConfig, it will now check if the value is empty and ignore it, so it does not trigger a controller error. Even though this is not required, users are expected to set this if they need to use access/secret key authentication. Controller behavior should not be changed if user provides a validS3CredentialSecretvalue.Which issue(s) this PR fixes:
Fixes #512
Special notes for your reviewer:
Checklist: