Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spin kube plugin to rddepman version checking #8061

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jandubois
Copy link
Member

No need to download it; we install the plugin via the spin plugin command.

Fixes #7814

No need to download it; we install the plugin via the `spin plugin` command.

Signed-off-by: Jan Dubois <[email protected]>
@jandubois jandubois force-pushed the rddepman-spin-kube-plugin branch from 6ad2875 to 47de29d Compare January 10, 2025 04:20
@mook-as mook-as self-assigned this Jan 10, 2025
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to some day clean things up and put all the dumb GitHub checking in a superclass. Some day.

@mook-as mook-as merged commit 660fc4b into rancher-sandbox:main Jan 10, 2025
20 checks passed
@jandubois jandubois deleted the rddepman-spin-kube-plugin branch January 10, 2025 19:42
@jandubois
Copy link
Member Author

I'd like to some day clean things up and put all the dumb GitHub checking in a superclass. Some day.

Yeah, I wanted that several times already as well. Some day, but not today...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rddepman support for spin kube plugin version
2 participants