rdctl: Don't use process groups on Linux #7965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
force-pushed
the
rdctl/linux-no-process-group
branch
2 times, most recently
from
4fdc6c1 to
a39654e
Compare
Disable killing all processes in the process on Linux, as Electron does not create a new process group when running from the RPM/deb package. Leave it using process groups on macOS, as launchd still does it. It is expected that we will revert this once we sort out process groups on Linux. Signed-off-by: Mark Yen <[email protected]>
mook-as
force-pushed
the
rdctl/linux-no-process-group
branch
from
a39654e to
ea31ee9
Compare
Nino-K
reviewed
Dec 18, 2024
| @@ -39,6 +40,12 @@ exit, and once it does, terminates all processes within the same process group.` | |||
| if err != nil { | |||
| return fmt.Errorf("failed to get process ID: %w", err) | |||
| } | |||
| if runtime.GOOS == "linux" { | |||
| // TODO: We can't use the process group on Linux, because Electron does | |||
There was a problem hiding this comment.
Do we need an issue for these TODOs?
There was a problem hiding this comment.
Good call; filed #7972 for that.
Nino-K
approved these changes
Dec 18, 2024
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable killing all processes in the process on Linux, as Electron does not create a new process group when running from the RPM/deb package. Leave it using process groups on macOS, as launchd still does it.
It is expected that we will revert this once we sort out process groups on Linux.
Fixes #7945