Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: enable CONFIG_SENSORS_DRIVETEMP and CONFIG_TASK_DELAY_ACCT #129

Conversation

smagellan
Copy link
Contributor

@smagellan smagellan commented Jan 11, 2025

Hello.
CONFIG_SENSORS_DRIVETEMP=m will build a module named drivetemp.ko. Which will in turn export e.g. hdd temp when loaded:

sensors(comes in lm-sensors package) output with drivetemp.ko loaded, note the drivetemp-scsi-0-0
root@rock-5-itx:/home/rock# sensors
npu_thermal-virtual-0
Adapter: Virtual device
temp1:        +24.1°C  (crit = +115.0°C)

center_thermal-virtual-0
Adapter: Virtual device
temp1:        +23.1°C  (crit = +115.0°C)

bigcore1_thermal-virtual-0
Adapter: Virtual device
temp1:        +24.1°C  (crit = +115.0°C)

soc_thermal-virtual-0
Adapter: Virtual device
temp1:        +23.1°C  (crit = +115.0°C)

drivetemp-scsi-0-0
Adapter: SCSI adapter
temp1:        +42.0°C  (low  = +10.0°C, high = +40.0°C)
                       (crit low =  +5.0°C, crit = +60.0°C)
                       (lowest = +26.0°C, highest = +44.0°C)

tcpm_source_psy_8_0022-i2c-8-22
Adapter: rk3x-i2c
in0:           0.00 V  (min =  +0.00 V, max =  +0.00 V)
curr1:         0.00 A  (max =  +0.00 A)

gpu_thermal-virtual-0
Adapter: Virtual device
temp1:        +23.1°C  (crit = +115.0°C)

littlecore_thermal-virtual-0
Adapter: Virtual device
temp1:        +24.1°C  (crit = +115.0°C)

bigcore0_thermal-virtual-0
Adapter: Virtual device
temp1:        +24.1°C  (crit = +115.0°C)

CONFIG_TASK_DELAY_ACCT=y helps some utilities (e.g. iotop, iotop-c) to gather more detailed statistics. One still needs to enable it in runtime via e.g. systemctl, kernel command line or interactively (e.g. iotop-c can do it for you).

Tested with Radxa ROCK 5 ITX

@smagellan smagellan force-pushed the feature/enable-CONFIG_SENSORS_DRIVETEMP-and-CONFIG_TASK_DELAY_ACCT-for-rk2312 branch from 46e37d8 to bc18b2f Compare January 11, 2025 12:42
@smagellan smagellan changed the title Please enable CONFIG_SENSORS_DRIVETEMP and CONFIG_TASK_DELAY_ACCT for rk2312 linux: rk2312: enable CONFIG_SENSORS_DRIVETEMP and CONFIG_TASK_DELAY_ACCT Jan 11, 2025
Copy link
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put generic config to linux/.common/kconfig.conf, and with comment describing why they are needed.

@smagellan smagellan force-pushed the feature/enable-CONFIG_SENSORS_DRIVETEMP-and-CONFIG_TASK_DELAY_ACCT-for-rk2312 branch 3 times, most recently from 46f7aca to dad28bb Compare January 13, 2025 09:55
@smagellan smagellan force-pushed the feature/enable-CONFIG_SENSORS_DRIVETEMP-and-CONFIG_TASK_DELAY_ACCT-for-rk2312 branch from dad28bb to 4d8ca58 Compare January 13, 2025 10:09
@smagellan
Copy link
Contributor Author

@RadxaYuntian done. Please take a look.

@smagellan smagellan changed the title linux: rk2312: enable CONFIG_SENSORS_DRIVETEMP and CONFIG_TASK_DELAY_ACCT linux: enable CONFIG_SENSORS_DRIVETEMP and CONFIG_TASK_DELAY_ACCT Jan 13, 2025
@RadxaYuntian RadxaYuntian added this pull request to the merge queue Jan 14, 2025
Merged via the queue into radxa-repo:main with commit c22f379 Jan 14, 2025
11 checks passed
@smagellan smagellan deleted the feature/enable-CONFIG_SENSORS_DRIVETEMP-and-CONFIG_TASK_DELAY_ACCT-for-rk2312 branch January 14, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants